On Tue, Oct 8, 2024 at 11:57:19AM +0530, Amit Kapila wrote:
> On Tue, Oct 8, 2024 at 6:25 AM Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Sun, Sep 29, 2024 at 06:33:29PM +0530, Amit Kapila wrote:
> > > > > It is better to write the above statement as:
> > > > > "pg_upgrade</application></link> now preserves replication slots on
> > > > > publishers and full subscription's state on subscribers". This is
> > > > > because replication slots are preserved on publishers. The subscribers
> > > > > preserve the subscription state.
> > > >
> > > > So, as I understand it, this preservation only happens when the _old_
> > > > Postgres version is 17+.
> > > >
> > >
> > > Yes.
> > >
> > > > Do we want to try and explain that in the
> > > > Postgres 17 release notes?
> > > >
> > >
> > > It would be good if we can capture that information without bloating
> > > the release document. However, this information is already present in
> > > pg_upgrade docs, so users have a way to know the same even if we can't
> > > mention it in the release notes.
> >
> > I have developed the attached patch to mention it is "logical" slots,
> > and to mention its future use.
> >
>
> LGTM. Thanks!
Great, patch applied.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
