Re: vacuumdb: permission denied for schema "pg_temp_7" - Mailing list pgsql-bugs

On Mon, Oct 07, 2024 at 12:40:54PM -0700, Noah Misch wrote:
> On Mon, Oct 07, 2024 at 11:16:33AM -0500, Nathan Bossart wrote:
>> For consistency with the surrounding code, I think we should schema-qualify
>> the operator and add a newline after "WHERE relpersistence != 't'".  If
>> folks agree, I can handle committing the attached patch.
> 
> Not just code consistency.  A code comment requires the schema qualification:
> 
>      * Since we execute the constructed query with the default search_path
>      * (which could be unsafe), everything in this query MUST be fully
>      * qualified.

D'oh.  I'm listed as the author of the commit that added that comment and
should've remembered it.  I'll just go apply the patch now, then.

-- 
nathan