On Tue, Sep 24, 2024 at 04:44:41PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> I think we should use INT64_FORMAT here. That'll choose the right length
>> modifier for the platform. And I don't think we need to cast MyStartTime,
>> since it's a pg_time_t (which is just an int64).
>
> Agreed. However, a quick grep finds half a dozen other places that
> are casting MyStartTime to long. We should fix them all.
+1
> Also note that if any of the other places are using translatable
> format strings, INT64_FORMAT is problematic in that context, and
> "long long" is a better answer for them.
At a glance, I'm not seeing any translatable format strings that involve
MyStartTime. But that is good to know...
--
nathan
