On Tue, Sep 24, 2024 at 11:49:12PM +0900, Fujii Masao wrote:
> On 2024/09/24 23:26, Nathan Bossart wrote:
>> Yeah, this is what I mentioned upthread [0]. If the user doesn't specify
>> anything in --table or --schema, then it's probably fine to silently skip
>> objects for which they lack privileges. But if they do explicitly specify
>> a table or schema that they cannot vacuum, then IMHO it'd be better to
>> fail.
>
> This could be debatable. To be honest, if I run something like vacuumdb mydb,
> *I* expect all eligible tables in that database to be vacuumed. If I forget to
> grant the necessary privileges to the role, I´d prefer to see errors from
> vacuumdb so I can fix the permissions.
>
> If we decide to skip tables without enough privilege, I´d prefer adding
> an option like --skip-unprivileged-tables rather than changing the default behavior.
I'm okay with that approach.
--
nathan
