Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
Date
Msg-id ZuSxg3CKsIBhzZhn@nathan
Whole thread Raw
In response to Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
List pgsql-hackers
On Fri, Sep 13, 2024 at 04:58:20PM -0400, Tom Lane wrote:
> Andrew Kane <andrew@ankane.org> writes:
>> With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and
>> `float_to_shortest_decimal_bufn` are not longer exported. This causes
>> `unresolved external symbol` linking errors for extensions that rely on
>> these functions (like pgvector). Can these functions be exported like
>> previous versions of Postgres?
> 
> AFAICS it's in the exact same place it was in earlier versions.
> You might need to review your linking commands.

I do see a fair amount of special handling for f2s.c in the build files.  I
wonder if something got broken for Windows in the switch from the MSVC
scripts to meson.

-- 
nathan



pgsql-hackers by date:

Previous
From: Florents Tselai
Date:
Subject: Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
Next
From: Marcos Pegoraro
Date:
Subject: Re: Detailed release notes