Re: remove volatile qualifiers from pg_stat_statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: remove volatile qualifiers from pg_stat_statements
Date
Msg-id ZrHK4dA3Mn7Of6hW@paquier.xyz
Whole thread Raw
In response to Re: remove volatile qualifiers from pg_stat_statements  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: remove volatile qualifiers from pg_stat_statements
List pgsql-hackers
On Wed, Jul 31, 2024 at 07:01:38AM +0000, Bertrand Drouvot wrote:
> I share the same understanding and I think those can be removed.
>
> The patch LGTM.

That sounds about right.  All the volatile references we have here
have been kept under the assumption that a memory barrier is required.
As we hold spin locks in these areas, that should not be necessary
anyway.  So LGTM as well.

A quick lookup at the rest of contrib/ is showing me that the
remaining volatile references point at uses with TRY/CATCH blocks,
where we require them.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Vitaly Davydov"
Date:
Subject: Fsync (flush) all inserted WAL records
Next
From: vignesh C
Date:
Subject: Re: Logical Replication of sequences