On Tue, Jul 09, 2024 at 05:23:03AM +0000, Bertrand Drouvot wrote:
> I gave a second thought on it, and I think that this is the "data" part that lead
> to the confusion (as too generic), what about?
>
> shared_data_len -> shared_stats_len
> shared_data_off -> shared_stats_off
>
> That looks ok to me even in the snapshot context (shared is fine after all
> because that's where the stats come from).
I'd tend to prefer the original suggestion because of the snapshot
context, actually, as the fixed-numbered stats in a snapshot are a
copy of what's in shmem, and that's not shared at all.
The rename is not the most important part, still if others have an
opinion, feel free.
--
Michael
