Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)
Date
Msg-id ZnjDoP_MZQefJfwJ@paquier.xyz
Whole thread Raw
In response to Avoid incomplete copy string (src/backend/access/transam/xlog.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On Sun, Jun 23, 2024 at 09:34:45PM -0300, Ranier Vilela wrote:
> It's not critical code, so I think it's ok to use strlen, even because the
> result of strlen will already be available using modern compilers.
>
> So, I think it's ok to use memcpy with strlen + 1.

It seems to me that there is a pretty good argument to just use
strlcpy() for the same reason as the one you cite: this is not a
performance-critical code, and that's just safer.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: replace strtok()
Next
From: Gurjeet Singh
Date:
Subject: Proposal: Division operator for (interval / interval => double precision)