Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid
Date
Msg-id ZkLyxju7_SDym-jU@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid
List pgsql-hackers
On Mon, May 13, 2024 at 01:01:21PM +0300, Aleksander Alekseev wrote:
>> Any objections to fixing this in 17 by removing it? (cc:ing Michael from the RMT)
>
> +1 Something that is not documented or used by anyone (apparently) and
> is broken should just be removed.

8a02339e9ba3 sounds like an argument good enough to prove there is no
demand in the field for being able to support options through initdb
--auth, and this does not concern only pam.  If somebody is interested
in that, that could always be done later.  My take is that this would
be simpler if implemented through a separate option, leaving the
checks between the options and the auth method up to the postmaster
when loading pg_hba.conf at startup.

Hence, no objections to clean up that now.  Thanks for asking.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Slow catchup of 2PC (twophase) transactions on replica in LR
Next
From: jian he
Date:
Subject: Re: SQL:2011 application time