Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date
Msg-id ZiXvxEKvh8cZpHFy@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
List pgsql-hackers
Tree view 
On Fri, Apr 19, 2024 at 12:47:43PM +0300, Aleksander Alekseev wrote:
> Thanks. I see a few pieces of code that use special FOO_NUMBER enum
> values instead of a macro. Should we refactor these pieces
> accordingly? PFA another patch.

I don't see why not for the places you are changing here, we can be
more consistent.  Now, such changes are material for v18.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: POC: GROUP BY optimization
Next
From: Alexander Lakhin
Date:
Subject: Re: fix tablespace handling in pg_combinebackup