Re: Autogenerate some wait events code and documentation - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Autogenerate some wait events code and documentation
Date
Msg-id Zg6VdOGrJpVcG30v@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: Autogenerate some wait events code and documentation  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Autogenerate some wait events code and documentation
List pgsql-hackers
Hi,

On Thu, Apr 04, 2024 at 07:14:47PM +0900, Michael Paquier wrote:
> On Thu, Apr 04, 2024 at 09:28:36AM +0000, Bertrand Drouvot wrote:
> > +# No "Backpatch" region here as code is generated automatically.
> > 
> > What about "....region here as has its own C code" (that would be more consistent
> > with the comment in the "header" for the file). Done that way in v4.
> 
> I'd add a "as -this section- has its own C code", for clarity.  This
> just looked a bit strange here.

Sounds good, done that way in v5 attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: promotion related handling in pg_sync_replication_slots()
Next
From: shveta malik
Date:
Subject: Re: Synchronizing slots from primary to standby