Re: Spurious pgstat_drop_replslot() call - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Spurious pgstat_drop_replslot() call
Date
Msg-id Ze_p-hmD_yFeVYXg@paquier.xyz
Whole thread Raw
In response to Re: Spurious pgstat_drop_replslot() call  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Spurious pgstat_drop_replslot() call
List pgsql-hackers
On Mon, Mar 11, 2024 at 04:15:40PM +0900, Michael Paquier wrote:
> That's a slight change in behavior, unfortunately, and it cannot be
> called a bug as this improves the visibility of the stats after an
> invalidation, so this is not something that can be backpatched.

I've looked again at that and that was OK on a second look.  May I
suggest the attached additions with LWLockHeldByMeInMode to make sure
that the stats are dropped and created while we hold
ReplicationSlotAllocationLock?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Regardign RecentFlushPtr in WalSndWaitForWal()
Next
From: Michael Paquier
Date:
Subject: Re: UUID v7