Re: Improve readability by using designated initializers when possible - Mailing list pgsql-hackers

On Fri, Mar 01, 2024 at 05:34:05AM +0100, Jelte Fennema-Nio wrote:

> diff --git a/src/include/mb/pg_wchar.h b/src/include/mb/pg_wchar.h
> index fd91aefbcb7..32e25a1a6ea 100644
> --- a/src/include/mb/pg_wchar.h
> +++ b/src/include/mb/pg_wchar.h
> @@ -225,7 +225,8 @@ typedef unsigned int pg_wchar;
>   * PostgreSQL encoding identifiers
>   *
>   * WARNING: If you add some encoding don't forget to update
> - *            the pg_enc2name_tbl[] array (in src/common/encnames.c) and
> + *            the pg_enc2name_tbl[] array (in src/common/encnames.c),
> + *            the pg_enc2gettext_tbl[] array (in src/common/encnames.c) and
>   *            the pg_wchar_table[] array (in src/common/wchar.c) and to check
>   *            PG_ENCODING_BE_LAST macro.

Mostly OK to me.  Just note that this comment is incorrect because
pg_enc2gettext_tbl[] includes elements in the range
[PG_SJIS,_PG_LAST_ENCODING_[  ;)
--
Michael