Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack
Date
Msg-id ZdlBFS25eKruiQvO@paquier.xyz
Whole thread Raw
In response to ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack  (Alexander Pyhalov <a.pyhalov@postgrespro.ru>)
Responses Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack
List pgsql-hackers
On Fri, Feb 23, 2024 at 01:21:14PM +0300, Alexander Pyhalov wrote:
> Recent commit 555276f8594087ba15e0d58e38cd2186b9f39f6d introduced final
> cleanup of node->as_eventset in ExecAppendAsyncEventWait().
> Unfortunately, now this function can return in the middle of TRY/FINALLY
> block, without restoring PG_exception_stack.
>
> We found this while working on our FDW. Unfortunately, I couldn't reproduce
> the issue with postgres_fdw, but it seems it is also affected.

Ugh, yes, you are obviously right that the early return is wrong.
I'll look into fixing that where appropriate.  Thanks for the report,
Alexander!
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Next
From: Michael Paquier
Date:
Subject: Re: Potential issue in ecpg-informix decimal converting functions