Re: Add lookup table for replication slot invalidation causes - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add lookup table for replication slot invalidation causes
Date
Msg-id Zdksqyj33Bvt71pc@paquier.xyz
Whole thread Raw
In response to Re: Add lookup table for replication slot invalidation causes  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On Fri, Feb 23, 2024 at 09:04:04AM +1100, Peter Smith wrote:
> I would've just removed every local variable instead of adding more of
> them. I also felt the iteration starting from RS_INVAL_NONE instead of
> 0 is asserting RS_INVAL_NONE must always be the first enum and can't
> be rearranged. Probably it will never happen, but why require it?

FWIW, I think that the code is OK as-is, so I'd just let it be for
now.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Printing backtrace of postgres processes
Next
From: Tristen Raab
Date:
Subject: Re: Documentation: warn about two_phase when altering a subscription