Re: int4->bool test coverage - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: int4->bool test coverage
Date
Msg-id Zbnj-mh_iS4HI4m2@paquier.xyz
Whole thread Raw
In response to Re: int4->bool test coverage  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, Dec 22, 2023 at 11:48:11AM +0900, Michael Paquier wrote:
> On Thu, Dec 21, 2023 at 11:56:22AM +0100, Christoph Berg wrote:
>> The first cast is the int4_bool function, but it isn't covered by the
>> regression tests at all. The attached patch adds tests.
>
> I don't see why not.

And one month later, done.

> Interesting that there are a few more of these in int.c, like int2up,
> int4inc, int2smaller, int{2,4}shr, int{2,4}not, etc.

I've left these out for now.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: possible inter-gcc-version incompatibility regarding fat objects
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Documentation to upgrade logical replication cluster