Hi,
On Mon, Jan 29, 2024 at 02:35:52PM +0530, Amit Kapila wrote:
> On Mon, Jan 29, 2024 at 2:22 PM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> > Looking at 0001:
> >
> > + When altering the
> > + <link linkend="sql-createsubscription-params-with-slot-name"><literal>slot_name</literal></link>,
> > + the <literal>failover</literal> property value of the named slot may differ from the
> > + <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
> > + parameter specified in the subscription. When creating the slot,
> > + ensure the slot <literal>failover</literal> property matches the
> > + <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
> > + parameter value of the subscription. Otherwise, the slot on the publisher may
> > + not be enabled to be synced to standbys.
> >
> > Not related to this patch series but while at it shouldn't we also add a few
> > words about two_phase too? (I mean ensure the slot property matchs the
> > subscription one).
> >
> > Or would it be better to create a dedicated patch (outside of this thread) for
> > the "two_phase" remark? (If so I can take care of it).
> >
>
> I think it is better to create a separate patch for two_phase after
> this patch gets committed.
Yeah, makes sense, will do, thanks!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
