Re: pgsql: Prevent redeclaration of typedef TocEntry. - Mailing list pgsql-committers

From Nathan Bossart
Subject Re: pgsql: Prevent redeclaration of typedef TocEntry.
Date
Msg-id Z_EsaH5Mt4BYINTQ@nathan
Whole thread Raw
In response to Re: pgsql: Prevent redeclaration of typedef TocEntry.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Sorry, I missed this one last night.

On Sat, Apr 05, 2025 at 02:10:10AM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
>> ... AFAICS we could move both DefnDumperPtr and
>> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct
>> _tocEntry (the only place where they are used), and we'd have less of a
>> mess here.  Then we don't need struct TocEntry in pg_backup.h anymore.
> 
> +1 for this simplification.

This is a better fix.  Thanks for taking care of it.

-- 
nathan



pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Clean up from commit 1495eff7bdb
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid double transformation of json_array()'s subquery.