Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Date
Msg-id Z_DoyQRKsq6XnS_F@paquier.xyz
Whole thread Raw
In response to Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
List pgsql-committers
Tree view 
On Sun, Mar 30, 2025 at 11:12:20AM -0700, Jeff Davis wrote:
> Why pg_strdup() the "NULL" at all in that case? Usually I see that done
> so that there doesn't need to be a conditional when freeing, but here
> there's a conditional anyway.
>
> Perhaps something like the attached?

I am back to a laptop, and just noticed that you have applied
f4e51eab4eb0 into the tree to take care of this issue, affecting only
HEAD.  Why didn't you do a backpatch of this commit down to v16?
That's down to where 2a083ab807db has been applied.
--
Michael
Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Prevent redeclaration of typedef TocEntry.
Next
From: Álvaro Herrera
Date:
Subject: pgsql: pg_dump: Tiny header cleanup