Re: Remove unneeded PGDATABASE setting from TAP tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove unneeded PGDATABASE setting from TAP tests
Date
Msg-id ZZDawEZbko5asmoi@paquier.xyz
Whole thread Raw
In response to Remove unneeded PGDATABASE setting from TAP tests  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Remove unneeded PGDATABASE setting from TAP tests
List pgsql-hackers
On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote:
> Some of the TAP tests are explicitly setting PGDATABASE environment
> variable to 'postgres', which isn't needed because the TAP test's perl
> library PostgreSQL::Test::Cluster already sets it once and for all.
> I've attached a patch that removes all such unneeded PGDATABASE
> settings.
>
> Thoughts?

Hmm.  I don't see any reason to not do that as these are not really
self-documenting either.  How about 011_clusterdb_all.pl for
PGDATABASE?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Exclude generated wait_event files from pgindent
Next
From: Matthias Kuhn
Date:
Subject: Build versionless .so for Android