Re: libpq: pipeline mode might desynchronize client and server - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: libpq: pipeline mode might desynchronize client and server
Date
Msg-id ZWAPMRqhifJ8YVNW@paquier.xyz
Whole thread Raw
In response to libpq: pipeline mode might desynchronize client and server  (Ivan Trofimov <i.trofimow@yandex.ru>)
Responses Re: libpq: pipeline mode might desynchronize client and server  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-bugs
On Wed, Nov 22, 2023 at 03:13:46AM +0300, Ivan Trofimov wrote:
> This is a follow up on
> https://www.postgresql.org/message-id/17948-fcace7557e449957@postgresql.org.

Is this the same bug as discussed on this other thread?  Why is there
a need for a second thread?

> Libpq in pipeline mode considers '< 2TDCEZ' a sufficient response to
> '> BDESS', when according to specification one more 'Z' is expected.
> This leads to client <-> server desynchronization, when libpq parses the
> very next message server sends (which is Z, as expected).
>
> A bit more context and a MRE:
> https://github.com/itrofimow/libpq_protocol_desync
>
> I'm pretty sure that this branch
https://github.com/postgres/postgres/blob/3af101ce8be8eeb0e8adc61e293b5d12989f68be/src/interfaces/libpq/fe-exec.c#L2124
> should be adjusted to handle the case and do not match error response
> against sync query.

Could you attach the test case to the original thread please (assuming
that this is the same problem)?  If this data is deleted by github,
then any data making a problem reproducible would be lost.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: Re: Misconfiguration on SSL for download.postgresql.org ?
Next
From: Alexander Lakhin
Date:
Subject: Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds