Re: Simplify if/else logic of walsender CreateReplicationSlot - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Simplify if/else logic of walsender CreateReplicationSlot
Date
Msg-id ZVsTykodhzhPQo1d@paquier.xyz
Whole thread Raw
In response to Simplify if/else logic of walsender CreateReplicationSlot  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Simplify if/else logic of walsender CreateReplicationSlot
List pgsql-hackers
On Mon, Nov 20, 2023 at 06:01:42PM +1100, Peter Smith wrote:
> While reviewing another patch I was looking at the walsender's static
> function CreateReplicationSlot
>
> I found that the current logic seemed to have some unnecessary if/else
> checking which can be simplified.

Good idea.  What you are suggesting here improves the readability of
this code, so +1.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove MSVC scripts from the tree
Next
From: Michael Paquier
Date:
Subject: Re: Use of backup_label not noted in log