Re: pgsql: Don't trust unvalidated xl_tot_len. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pgsql: Don't trust unvalidated xl_tot_len.
Date
Msg-id ZVAavEe8DdyyJEN1@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Don't trust unvalidated xl_tot_len.  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Sun, Nov 12, 2023 at 12:17:54PM +1300, Thomas Munro wrote:
> No opinion on potential advantages to other approaches, but I don't
> see why this way shouldn't be expected to work.  So I hope you can
> drop that diff.

Another thing that could be done in stable branches is just to switch
039_end_of_wal.pl to hardcoded values for $XLP_PAGE_MAGIC and
$XLP_FIRST_IS_CONTRECORD.  This is not going to change in a released
version anyway, so there's no real maintenance cost.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Next
From: Andres Freund
Date:
Subject: Re: autovectorize page checksum code included elsewhere