Re: Call pqPipelineFlush from PQsendFlushRequest - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Call pqPipelineFlush from PQsendFlushRequest
Date
Msg-id ZUoeZTxxuTnlvLrh@paquier.xyz
Whole thread Raw
In response to Call pqPipelineFlush from PQsendFlushRequest  (Jelte Fennema-Nio <postgres@jeltef.nl>)
Responses Re: Call pqPipelineFlush from PQsendFlushRequest
Re: Call pqPipelineFlush from PQsendFlushRequest
List pgsql-hackers
On Tue, Nov 07, 2023 at 10:38:04AM +0100, Jelte Fennema-Nio wrote:
> In pipeline mode after queuing a message to be sent we would flush the
> buffer if the size of the buffer passed some threshold. The only message
> type that we didn't do that for was the Flush message. This addresses
> that oversight.
>
> I noticed this discrepancy while reviewing the
> PQsendSyncMessage/PQpipelinePutSync patchset.

Indeed, it looks a bit strange that there is no flush if the buffer
threshold is reached once the message is sent, so your suggestion
sounds right.  Alvaro?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Relids instead of Bitmapset * in plannode.h
Next
From: Heikki Linnakangas
Date:
Subject: Re: ResourceOwner refactoring