Re: Tab completion for AT TIME ZONE - Mailing list pgsql-hackers

On Fri, Apr 14, 2023 at 12:05:25PM +0200, Jim Jones wrote:
> The patch applies cleanly and it does what it is proposing. - and it's IMHO
> a very nice addition.
>
> I've marked the CF entry as "Ready for Committer".

+/* ... AT TIME ZONE ... */
+    else if (TailMatches("AT"))
+        COMPLETE_WITH("TIME ZONE");
+    else if (TailMatches("AT", "TIME"))
+        COMPLETE_WITH("ZONE");
+    else if (TailMatches("AT", "TIME", "ZONE"))
+        COMPLETE_WITH_TIMEZONE_NAME();

This style will for the completion of timezone values even if "AT" is
the first word of a query.  Shouldn't this be more selective by making
sure that we are at least in the context of a SELECT query?
--
Michael