Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly
Date
Msg-id ZRIm06ISiYWq4ivF@paquier.xyz
Whole thread Raw
In response to Re: Doesn't pgstat_report_wal() handle the argument "force" incorrectly  (Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>)
List pgsql-hackers
On Mon, Sep 25, 2023 at 02:49:50PM +0900, Ryoga Yoshida wrote:
> On 2023-09-25 14:38, Michael Paquier wrote:
>> Another idea would be to do like in pgstat.c by adding the following
>> line, then use "nowait" to call each sub-function:
>> nowait = !force;
>> pgstat_flush_wal(nowait);
>> pgstat_flush_io(nowait);
>
> That's very clear and I think it's good.

Done this way down to 15, then, with more comment polishing.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Doc: vcregress .bat commands list lacks "taptest"
Next
From: Peter Smith
Date:
Subject: Re: Add 'worker_type' to pg_stat_subscription