Re: [PATCH] fastpacth-locks compile time options - Mailing list pgsql-hackers

On Mon, Sep 18, 2023 at 05:49:51PM +0300, Sergey Sergey wrote:
> Hope this patch will be usefull/

-    uint64       fpLockBits;        /* lock modes held for each fast-path slot */
+    uint8        fpLockBits[FP_LOCK_SLOTS_PER_BACKEND];        /* lock modes

If my maths are right, this makes PGPROC 8 bytes larger with 16 slots
by default.  That is not a good idea.

+  --runstatedir=DIR       modifiable per-process data [LOCALSTATEDIR/run]

And this points out that ./configure has been generated with one of
Debian's autoreconf commands, which is something to avoid.

I am not sure that this patch is a good idea long-term.  Wouldn't it
be better to invent new and more scalable concepts able to tackle
bottlenecks around these code paths instead of using compile-time
tweaks like that?
--
Michael