On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote:
> On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote:
> > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> >> IMO the phrase "open a port" is kind of nonstandard. I think we should say
> >> something along the lines of
> >>
> >> If listen_addresses is not empty, the server will start only if it can
> >> listen on at least one of the specified addresses. A warning will be
> >> emitted for any addresses that the server cannot listen on.
> >
> > Good idea, updated patch attached.
>
> I still think we should say "listen on an address" instead of "open a
> port," but otherwise it LGTM.
Agreed, I never liked the "port" mention. I couldn't figure how to get
"open" out of the warning sentence though. Updated patch attached.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
