Re: [PoC] pg_upgrade: allow to upgrade publisher node - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PoC] pg_upgrade: allow to upgrade publisher node
Date
Msg-id ZP/hnAbrCQMSp6aQ@paquier.xyz
Whole thread Raw
In response to RE: [PoC] pg_upgrade: allow to upgrade publisher node  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
Responses RE: [PoC] pg_upgrade: allow to upgrade publisher node
List pgsql-hackers
On Tue, Sep 12, 2023 at 02:33:25AM +0000, Zhijie Hou (Fujitsu) wrote:
> 2.
> +        if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
> +            elog(ERROR, "Replication slots must not be invalidated during the upgrade.");
>
> I think normally the first letter is lowercase, and we can avoid the period.

Documentation is your friend:
https://www.postgresql.org/docs/current/error-style-guide.html
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: PSQL error: total cell count of XXX exceeded
Next
From: Tom Lane
Date:
Subject: Re: PSQL error: total cell count of XXX exceeded