Re: Avoid possible memory leak (src/common/rmtree.c) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Avoid possible memory leak (src/common/rmtree.c)
Date
Msg-id ZMR/eCCVxaFYcL0s@paquier.xyz
Whole thread Raw
In response to Re: Avoid possible memory leak (src/common/rmtree.c)  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Avoid possible memory leak (src/common/rmtree.c)
List pgsql-hackers
On Tue, Jul 25, 2023 at 04:45:22PM +0200, Daniel Gustafsson wrote:
> Skimming the tree there doesn't seem to be any callers which aren't exiting or
> ereporting on failure so the real-world impact seems low.  That being said,
> silencing static analyzers could be reason enough to delay allocation.

A different reason would be out-of-core code that uses rmtree() in a
memory context where the leak would be an issue if facing a failure
continuously?  Delaying the allocation after the OPENDIR() seems like
a good practice anyway.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Support worker_spi to execute the function dynamically.
Next
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition