Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Check more invariants during syscache initialization - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Check more invariants during syscache initialization
Date
Msg-id ZMHC6sq7qQSB7Zoz@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Check more invariants during syscache initialization  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Check more invariants during syscache initialization
List pgsql-hackers
Tree view 
On Wed, Jul 26, 2023 at 03:28:55PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Shouldn't these be calling `OidIsValid(…)`, not comparing directly to
> `InvalidOid`?

I think that they should use OidIsValid() on correctness ground, and
that's the style I prefer.  Now, I don't think that these are worth
changing now except if some of the surrounding code is changed for a
different reason.  One reason is that this increases the odds of
conflicts when backpatching on a stable branch.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Improve pg_stat_statements by making jumble handle savepoint names better
Next
From: Peter Smith
Date:
Subject: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication