On Wed, Jul 05, 2023 at 10:14:22AM -0400, Greg Sabino Mullane wrote:
> Would like to hear others weigh in, I think it's still only three states
> plus a default, so I'm not convinced it warrants multiple statements yet. :)
I find that hard to parse, so having more lines to get a better idea
of what the states are would be good.
While on it, I can see that the patch has no tests. Could you add
something in psql's 001_basic.pl? The option to define the number of
iterations for \watch can make the tests predictible even for the
non-failure cases. I would do checks with incorrect values, as well,
see the part of the test script about the intervals.
--
Michael
