Postgres Pro
Downloads
Home   >   mailing lists

Re: Another incorrect comment for pg_stat_statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Another incorrect comment for pg_stat_statements
Date
Msg-id ZJvi/Y9tXVsbmdNk@paquier.xyz
Whole thread Raw
In response to Re: Another incorrect comment for pg_stat_statements  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Another incorrect comment for pg_stat_statements
List pgsql-hackers
Tree view 
On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote:
> +1.  To nitpick, how about we remove the blank line just before removing
> the key for top level entry?
>
> -  /* Also remove entries for top level statements */
> +  /* Also remove entries if exist for top level statements */
>    key.toplevel = true;
> -
> -  /* Remove the key if exists */
>    entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);

Why not if it improves the overall situation.  Could you send a patch
with everything you have in mind?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
Next
From: Daniel Gustafsson
Date:
Subject: Commitfest manager for July