Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
Date
Msg-id ZJp33BFjz6eTYquR@paquier.xyz
Whole thread Raw
In response to [PATCH] Honor PG_TEST_NOCLEAN for tempdirs  (Jacob Champion <jchampion@timescale.com>)
Responses Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
List pgsql-hackers
On Mon, Jun 26, 2023 at 04:55:47PM -0700, Jacob Champion wrote:
> I was running the test_pg_dump extension suite, and I got annoyed that
> I couldn't keep it from deleting its dump artifacts after a successful
> run. Here's a patch to make use of PG_TEST_NOCLEAN (which currently
> covers the test cluster's base directory) with the Test::Utils
> tempdirs too.

I am still +1 in doing that.

> (Looks like this idea was also discussed last year [1]; let me know if
> I missed any more recent suggestions.)

I don't recall any specific suggestions related to that, but perhaps
it got mentioned somewhere else.

src/test/perl/README and regress.sgml both describe what
PG_TEST_NOCLEAN does, and it seems to me that these should be updated
to tell that temporary files are not removed on top of the data
folders?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ReadRecentBuffer() doesn't scale well
Next
From: Ashutosh Bapat
Date:
Subject: Re: logical decoding and replication of sequences, take 2