Re: v16 fails to build w/ Visual Studio 2015 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: v16 fails to build w/ Visual Studio 2015
Date
Msg-id ZIZplH/o7DIWQ8GY@paquier.xyz
Whole thread Raw
In response to Re: v16 fails to build w/ Visual Studio 2015  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On Wed, Jun 07, 2023 at 11:35:34PM +0200, Peter Eisentraut wrote:
> I kind of like the style where there is only one return at the end, because
> it makes it easier to inject debugging code that inspects the return value.

I kind of disagree here, the previous style is a bit ugly-ish, with
the code generated by gen_node_support.pl being dependent on this
local call because it is necessary to know about return_value:
-   if (false)
-       ;
 #include "readfuncs.switch.c"

So +1 for what's proposed.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Next
From: Michael Paquier
Date:
Subject: Re: v16 fails to build w/ Visual Studio 2015