Re: Make pgbench exit on SIGINT more reliably - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Make pgbench exit on SIGINT more reliably
Date
Msg-id ZG1a5lsSXXiYVJQ6@paquier.xyz
Whole thread Raw
In response to Make pgbench exit on SIGINT more reliably  ("Tristan Partin" <tristan@neon.tech>)
Responses Re: Make pgbench exit on SIGINT more reliably
Re: Make pgbench exit on SIGINT more reliably
List pgsql-hackers
On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote:
> The way that pgbench handled SIGINT changed in
> 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortunately this had a
> couple of unintended consequences, at least from what I can tell[1].
>
> - CTRL-C no longer stops the program unless the right point in pgbench
>   execution is hit
> - pgbench no longer exits with a non-zero exit code
>
> An easy reproduction of these problems is to run with a large scale
> factor like: pgbench -i -s 500000. Then try to CTRL-C the program.

This comes from the code path where the data is generated client-side,
and where the current CancelRequested may not be that responsive,
isn't it?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: RFI: Extending the TOAST Pointer
Next
From: Thomas Munro
Date:
Subject: Re: Large files for relations