Re: Add regression test checking combinations of (object,backend_type,context) in pg_stat_io - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add regression test checking combinations of (object,backend_type,context) in pg_stat_io
Date
Msg-id Z8hBRJrHqnsgc2An@paquier.xyz
Whole thread Raw
In response to Re: Add regression test checking combinations of (object,backend_type,context) in pg_stat_io  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On Wed, Mar 05, 2025 at 07:34:16AM +0000, Bertrand Drouvot wrote:
> That would mean changing the test each time pgstat_tracks_io_object() is
> modified in such a way that the output is changed. That's a good thing as
> the writer will need to double check if the new output makes sense according
> to his changes. So I don't see any reason not to add this test.

Thanks for the review.

> What about adding some extra paranoia like?
>
> SELECT backend_type, object, context FROM pg_stat_io ORDER BY
> backend_type, object, context COLLATE "C";

Why not, to force the ordering.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Make tuple deformation faster
Next
From: Michael Paquier
Date:
Subject: Re: Monitoring gaps in XLogWalRcvWrite() for the WAL receiver