On Thu, Feb 27, 2025 at 07:47:09AM +0000, Bertrand Drouvot wrote:
> That's how I did it initially but decided to move it to pgstat_backend.c. The
> reason was that it's fully linked to "per backend" stats and that there is
> no SQL api on top of it (while I think that's the case for almost all the ones
> in pgstatfuncs.c). Thoughts?
Okay by me with pgstat_fetch_stat_backend in parallel, why not
exposing this part as well.. Perhaps that could be useful for some
extension? I'd rather have out-of-core code do these lookups with the
same sanity checks in place for the procnumber and slot lookups.
The name was inconsistent with the rest of the file, so I have settled
to a pgstat_fetch_stat_backend_by_pid() to be more consistent. A
second thing is to properly initialize bktype if defined by the
caller.
> Makes sense. I did not had in mind to submit a new patch version (to at least
> implement the above) without getting your final thoughts on your first comment.
> But since a rebase is needed anyway,then please find attached a new version. It
> just implements your last comment.
Attached is a rebased version of the rest.
--
Michael
