On Wed, Feb 26, 2025 at 12:33:16PM +0300, Maxim Orlov wrote:
> Done. Except for a new name for "logit" variable. Unfortunately, I can't
> think of anything sane. As an example I looked at sequence.c. The same name
> is used there. I will gladly change this name to whatever you want if it
> still look misleading or incomplete for you in some way or another. Just
> write the name that you think is correct.
"old_pss_pid", because this is an old pss_pid value from a previous
slot. Keeping the value around after releasing the slot is also
useful for debugging, so rather than a boolean it is possible to use a
uint32. The "sanity check" comment was also a bit out-of-order
because it was written just before acquiring the spinlock.
Tweaked a bit the whole, and the result looked OK so applied on HEAD.
--
Michael
