Postgres Pro
Downloads
Home   >   mailing lists

Re: Unneeded volatile qualifier in fmgr.c - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Unneeded volatile qualifier in fmgr.c
Date
Msg-id Z6xevtT9vDJA2tcX@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
Responses Re: Unneeded volatile qualifier in fmgr.c
List pgsql-hackers
Tree view 
Hi,

On Wed, Feb 12, 2025 at 04:25:38PM +0800, Julien Rouhaud wrote:
> Hi,
> 
> While reading some code in fmgr.c I noticed that the save_nestlevel variable is
> declared as volatile.  I'm assuming that's because a long time ago it was
> modified in the PG_TRY / PG_CATCH block but it doesn't look needed anymore.
> 
> Trivial patch attached.

Yeah, makes sense to me.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Shubham Khanna
Date:
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Next
From: Andrei Lepikhov
Date:
Subject: Re: explain analyze rows=%.0f