Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove a unnecessary argument from execute_extension_script() - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Remove a unnecessary argument from execute_extension_script()
Date
Msg-id Z65y6kMZj-7qkaMC@nathan
Whole thread Raw
In response to Re: Remove a unnecessary argument from execute_extension_script()  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
Responses Re: Remove a unnecessary argument from execute_extension_script()
List pgsql-hackers
Tree view 
On Thu, Feb 13, 2025 at 03:18:51PM -0300, Fabrízio de Royes Mello wrote:
> On Thu, Feb 13, 2025 at 1:02 PM Yugo Nagata <nagata@sraoss.co.jp> wrote:
>> The attached patch is to remove a unnecessary argument "schemaOid"
>> from the static function execute_extension_script(). It might have
>> been intended to be used some way initially, but actually this is
>> not used since schemaName is sufficient.
> 
> LGTM.

Interesting.  This parameter seems to have appeared between v30 [0] and v31
[1] of the original extension patch, and even then it wasn't used.  And
from a quick skim, I don't see any discussion about it.  I'll plan on
committing this shortly.

[0] https://postgr.es/m/m24o8nhd69.fsf%402ndQuadrant.fr
[1] https://postgr.es/m/4171.1297135840%40sss.pgh.pa.us

-- 
nathan

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)
Next
From: Nathan Bossart
Date:
Subject: Re: pg17.3 PQescapeIdentifier() ignores len