Re: Fix a wrong errmsg in AlterRole() - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Fix a wrong errmsg in AlterRole()
Date
Msg-id Z364U3jVLD2-pcU_@nathan
Whole thread Raw
In response to Re: Fix a wrong errmsg in AlterRole()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jan 08, 2025 at 10:29:12AM -0500, Tom Lane wrote:
> "=?ISO-8859-1?B?Y2NhNTUwNw==?=" <cca5507@qq.com> writes:
>> postgres=> alter group g1 drop user r1;
>> ERROR:  permission denied to alter role
>> DETAIL:  Only roles with the ADMIN option on role "g1" may add members.
> 
>> The errmsg is "add members", but we are doing a drop.
>> Here is a small patch to fix it.
> 
> Hmm.  Seems simpler to just make the errdetail say "... may add or
> drop members."

+1.  It looks like this goes back to commit ce6b672 (v16).  The error
message was changed in commit de4d456, which is also a v16 change, so
fortunately this has a good chance of back-patching cleanly.

-- 
nathan



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: jsonb_strip_nulls with arrays?
Next
From: Bruce Momjian
Date:
Subject: Re: Fwd: Re: A new look at old NFS readdir() problems?