Re: shared-memory based stats collector - v70 - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: shared-memory based stats collector - v70
Date
Msg-id Z1fi3nAoI1pXpshr@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
In response to Re: shared-memory based stats collector - v70  ("Anton A. Melnikov" <a.melnikov@postgrespro.ru>)
List pgsql-hackers
Hi,

On Tue, Dec 10, 2024 at 09:54:36AM +0900, Michael Paquier wrote:
> On Mon, Dec 09, 2024 at 08:03:54AM +0000, Bertrand Drouvot wrote:
> > Right. OTOH I think that could help the tap test added in da99fedf8c to not
> > rely on assert enabled build (the tap test could "simply" check for the
> > WARNING in the logfile instead).
> 
> That's true.  Still, the coverage that we have is also enough for
> assert builds, which is what the test is going to run with most of the
> time anyway.

Yeah, that's fine by me and don't see the added value of the WARNING then.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Michael Harris
Date:
Subject: Re: FileFallocate misbehaving on XFS
Next
From: Andy Fan
Date:
Subject: Re: testing framework for MVCC & vacuum (freeze) & heap_page_prune etc.