Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_create_logical_replication_slot argument incongruency - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_create_logical_replication_slot argument incongruency
Date
Msg-id YykYZI8RChKycDe9@paquier.xyz
Whole thread Raw
In response to pg_create_logical_replication_slot argument incongruency  (Florin Irion <irionr@gmail.com>)
Responses Re: pg_create_logical_replication_slot argument incongruency
List pgsql-hackers
Tree view 
On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
> This was introduced in commit 19890a06.
>
> IMHO we should use the documented argument name `two_phase` and change the
> function to accept it.
>
> What do you think?

19890a0 is included in REL_14_STABLE, and changing an argument name is
not acceptable in a stable branch as it would imply a catversion
bump.  Let's change the docs so as we document the parameter as
"twophase", instead.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: pg_upgrade test failure
Next
From: Michael Paquier
Date:
Subject: Re: Refactor backup related code (was: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?)