Re: Improve TAP tests of pg_upgrade for cross-version tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Improve TAP tests of pg_upgrade for cross-version tests
Date
Msg-id YuTdzCf0pvuqVlYY@paquier.xyz
Whole thread Raw
In response to Re: Improve TAP tests of pg_upgrade for cross-version tests  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Improve TAP tests of pg_upgrade for cross-version tests
List pgsql-hackers
On Fri, Jul 29, 2022 at 04:15:26PM -0500, Justin Pryzby wrote:
> This was using the old psql rather than the new one.
> Before v10, psql didn't have \if.

        # Note that upgrade_adapt.sql from the new version is used, to
    # cope with an upgrade to this version.
-       $oldnode->command_ok(
+       $newnode->command_ok(
                [
-                       'psql', '-X',
+                       "$newbindir/psql", '-X',

Yeah, you are right here that this psql command should use the one
from the new cluster and connect to the old cluster.  There is no
point in adding $newbindir though as Cluster::_get_env would enforce
PATH to find the correct binary.  I'll look at that in details later.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Support for grabbing multiple consecutive values with nextval()
Next
From: Julien Rouhaud
Date:
Subject: Re: Allow file inclusion in pg_hba and pg_ident files