Re: defGetBoolean - Fix comment - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: defGetBoolean - Fix comment
Date
Msg-id YsYuwFloB3NVEi4q@paquier.xyz
Whole thread Raw
In response to defGetBoolean - Fix comment  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: defGetBoolean - Fix comment
List pgsql-hackers
On Thu, Jul 07, 2022 at 09:53:01AM +1000, Peter Smith wrote:
> Really this code is for the case when there *was* a parameter given
> (e.g. "copy_data" in my example above) but when there is no parameter
> *value* given.
>
> Suggested comment fix:
> BEFORE
> If no parameter given, assume "true" is meant.
> AFTER
> If no parameter value given, assume "true" is meant.

Still, I think that your adjustment is right, as the check is, indeed,
on the DefElem's value*.  Or you could just say "If no value given".
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Next
From: Michael Paquier
Date:
Subject: Re: pg_parameter_aclcheck() and trusted extensions