Re: convert libpq uri-regress tests to tap test - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: convert libpq uri-regress tests to tap test
Date
Msg-id YpWgcbXZD4FAdz5a@paquier.xyz
Whole thread Raw
In response to Re: convert libpq uri-regress tests to tap test  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: convert libpq uri-regress tests to tap test
List pgsql-hackers
On Sun, May 29, 2022 at 10:18:50AM -0500, Justin Pryzby wrote:
> On Sat, Feb 26, 2022 at 05:46:26PM -0800, Andres Freund wrote:
> > On 2022-02-25 17:52:29 -0800, Andres Freund wrote:
> > > I'd like to commit 0001 and 0002 soon, unless somebody sees a reason not to?
> >
> > Pushed.
>
> If I'm not wrong, this isn't being run by check-world.

You are right.

> -$(call recurse,check-world,src/test src/pl src/interfaces/ecpg contrib src/bin,check)
> -$(call recurse,checkprep,  src/test src/pl src/interfaces/ecpg contrib src/bin)
> +$(call recurse,check-world,src/test src/pl src/interfaces/ecpg src/interfaces/libpq contrib src/bin,check)
> +$(call recurse,checkprep,  src/test src/pl src/interfaces/ecpg src/interfaces/libpq contrib src/bin)
>
> -$(call recurse,installcheck-world,src/test src/pl src/interfaces/ecpg contrib src/bin,installcheck)
> +$(call recurse,installcheck-world,src/test src/pl src/interfaces/ecpg src/interfaces/libpq contrib
src/bin,installcheck)
>  $(call recurse,install-tests,src/test/regress,install-tests)

Why don't you just use src/interfaces/ instead of adding a direct
path to libpq?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Failures in sto_using_cursor test
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485)