Re: Proposal: More structured logging - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Proposal: More structured logging
Date
Msg-id Yk6ISh9NKeFUc15r@paquier.xyz
Whole thread Raw
In response to Re: Proposal: More structured logging  (Greg Stark <stark@mit.edu>)
List pgsql-hackers
On Mon, Jan 31, 2022 at 05:46:29PM -0500, Greg Stark wrote:
> It looks strange to me that the errorTag struct has a "const char
> *tagname" but a "char *tagvalue". I think this is a side effect of the
> code and not actually a sensible way to define the struct. Surely they
> should both be const?

This review has not been answered, and it was around for two months
now.  I am marking this patch as returned with feedback.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Add native windows on arm64 support
Next
From: Andres Freund
Date:
Subject: Re: Extensible Rmgr for Table AMs