Re: refactoring basebackup.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: refactoring basebackup.c
Date
Msg-id YfCj+QFS6hKlcscJ@paquier.xyz
Whole thread Raw
In response to Re: refactoring basebackup.c  (tushar <tushar.ahuja@enterprisedb.com>)
List pgsql-hackers
On Tue, Jan 25, 2022 at 09:52:12PM +0530, tushar wrote:
> C) -R option is silently ignoring
>
> go to /tmp/pp folder and extract it - there is no "standby.signal" file and
> if we start cluster against this data directory,it will not be in slave
> mode.

Yeah, I don't think it's good to silently ignore the option, and we
should not generate the file on the server-side.  Rather than erroring
in this case, you'd better add the file to the existing compressed
file of the base data folder on the client-side.

This makes me wonder whether we should begin tracking any open items
for v15..  We don't want to lose track of any issue with features
committed already in the tree.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: refactoring basebackup.c
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: row filtering for logical replication