Re: Refactoring of compression options in pg_basebackup - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Refactoring of compression options in pg_basebackup
Date
Msg-id YeuaSyPyS1ssrzw0@paquier.xyz
Whole thread Raw
In response to Re: Refactoring of compression options in pg_basebackup  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Refactoring of compression options in pg_basebackup
List pgsql-hackers
On Fri, Jan 21, 2022 at 09:57:41AM -0500, Robert Haas wrote:
> Thanks. One thing I just noticed is that the enum we're using here is
> called WalCompressionMethod. But we're not compressing WAL. We're
> compressing tarfiles of the data directory.

Also, having this enum in walmethods.h is perhaps not the best place
either, even more if you plan to use that in pg_basebackup for the
server-side compression.  One idea is to rename this enum to
DataCompressionMethod, moving it into a new header, like common.h as
of the attached.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Document atthasmissing default optimization avoids verification table scan
Next
From: "David G. Johnston"
Date:
Subject: Re: Skipping logical replication transactions on subscriber side